There is a lot of hoopla about Camelot, what America would look like if JFK had had two terms and so on. The reality is that he would never been elected a second time.
He made many enemies. Corrupt unions, J. Edgar Hoover, the CIA, many Republicans and more. And he was vulnerable.
Hoover had hard evidence of his sexual activity, including his dalliances with Judith Exner, who was concurrently screwing Sam Giancana, head of the Chicago mob. The Republicans also had hard information of many, many indescretions, and were planning on releasing it before the next general election. The CIA was fed up with him, had information, and the means to disseminate it. They were also willing.
JFK had set himself up as a devoted family man, and the American people would have responded to the truth about him rather energetically. In those days Americans didn’t like being fooled, didn’t like security risks, didn’t like liars. And the Democratic party establishment would have been bitter for having as a leader someone who could fall so far so fast.
Nope. JFK, in order to be a highly regarded President had to die when he did. Much longer and he would have been disgraced.